Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add configurations for demo and product deployment on eks #2714

Merged
merged 5 commits into from
Jun 15, 2020
Merged

add configurations for demo and product deployment on eks #2714

merged 5 commits into from
Jun 15, 2020

Conversation

DanielZhangQD
Copy link
Contributor

What problem does this PR solve?

Fix #2668

What is changed and how does it work?

Add different configurations for demo and product deployment on eks

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
    • Deploy TiDB Clusters with the two configurations on EKS

Code changes

  • Has Terraform scripts change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

weekface
weekface previously approved these changes Jun 15, 2020
View reviewed changes
Yisaer
Yisaer previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, plz fit the format error

@DanielZhangQD DanielZhangQD dismissed stale reviews from Yisaer and weekface via 5ccdf76 June 15, 2020 09:36
weekface
weekface previously approved these changes Jun 15, 2020
View reviewed changes
@DanielZhangQD DanielZhangQD mentioned this pull request Jun 15, 2020
Merged
3 tasks
@DanielZhangQD
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 2718

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 27bd820 into pingcap:master Jun 15, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jun 15, 2020
@DanielZhangQD @ti-srebot
cherry pick pingcap#2714 to release-1.1
ee1b53f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #2721

@DanielZhangQD DanielZhangQD deleted the eks0 branch June 15, 2020 13:52
ti-srebot added a commit that referenced this pull request Jun 15, 2020
@ti-srebot @DanielZhangQD
add configurations for demo and product deployment on eks (#2714) (#2721
1980b29 
)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
@ti-srebot ti-srebot mentioned this pull request Jun 18, 2020
Merged
3 tasks
@shenli shenli mentioned this pull request Jun 29, 2020
Merged
3 tasks
@ti-srebot ti-srebot mentioned this pull request Jul 2, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@weekface weekface weekface approved these changes

@cofyc cofyc Awaiting requested review from cofyc

Assignees
No one assigned
Labels
CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update instance type for TiKV on EKS
4 participants
@DanielZhangQD @ti-srebot @weekface @Yisaer