Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document tool setup and e2e test detail in Contributing.md #288

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Feb 26, 2019

close #287
Signed-off-by: Yeh-lei Wu rayingecho@gmail.com

Signed-off-by: Yeh-lei Wu <rayingecho@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Feb 26, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit c8e9cb5 into pingcap:master Feb 27, 2019
shuijing198799 pushed a commit to shuijing198799/tidb-operator that referenced this pull request Mar 15, 2019
* Document tool setup and e2e test detail in Contributing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

facing "ginkgo: command not found" when following the contribution guide
4 participants