Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use k8s.gcr.io vanity domain #2908

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Use k8s.gcr.io vanity domain #2908

merged 1 commit into from
Jul 14, 2020

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Jul 13, 2020

What problem does this PR solve?

gcr.io/google_containers is deprecated, see kubernetes/release#270

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@cofyc cofyc requested review from DanielZhangQD and lichunzhu July 13, 2020 02:18
DanielZhangQD
DanielZhangQD approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@DanielZhangQD,Thanks for your review.

@cofyc cofyc requested a review from weekface July 13, 2020 08:30
lichunzhu
lichunzhu approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@lichunzhu,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: k8s(slack).

@cofyc
Copy link
Contributor Author

cofyc commented Jul 14, 2020

@lichunzhu,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: k8s(slack).

ignore this...

@cofyc cofyc merged commit a1ec5f0 into pingcap:master Jul 14, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jul 14, 2020
@cofyc @ti-srebot
cherry pick pingcap#2908 to release-1.1
c434a89 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #2921

ti-srebot added a commit that referenced this pull request Jul 14, 2020
@ti-srebot @cofyc
Use k8s.gcr.io vanity domain (#2908) (#2921)
ec7b4d0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@weekface weekface Awaiting requested review from weekface

Assignees
No one assigned
Labels
needs-cherry-pick-1.1 status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cofyc @ti-srebot @lichunzhu @DanielZhangQD