Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically set the scheduler K8s version #313

Merged
merged 4 commits into from
Mar 15, 2019
Merged

Conversation

gregwebs
Copy link
Contributor

This is tested to work on GKE. If this approach is approved, we will need to update some docs.

There is some relation to #278: after this change one should perform a helm upgrade when the K8s version changes (normally this would only matter for a major version change).

It is also possible to try to construct the string from Capabilities.KubeVersion.Major + Capabilities.KubeVersion.Minor.
However, that give me 1.12+ rather than 1.12.5. So the GitVersion approach seems to match our user guide.

This is tested to work on GKE
@tennix
Copy link
Member

tennix commented Mar 13, 2019

This looks great! Previously we use hyperkube image built by coreos hosted on quay.io. And the image is quay.io/coreos/hyperkube:v1.10.2_coreos.0, but the GitVersion returned by apiserver is v1.10.2+coreos.0. So this approach doesn't works. But now after CoreOS is acquired by RedHat, quay.io doesn't have newer versions (>= v1.11) of hyperkube image.

I'm not sure if this can still work for other registry images and I guess it's quite fragile. But if it works for gcr.io/google-containers/hyperkube I think we can add this to values.yaml to improve GKE users' experience and notify user in the documentation that this is only tested on GKE.

@gregwebs
Copy link
Contributor Author

Users on other platforms besides GKE will still pull this pulbic image from the gcr.io without issue (unless they are behind the GFW). But yes, their GitVersion may not match. We should be able to make a more complicated function that can accomodate different environments. For example that can also remove the +.

tennix
tennix previously approved these changes Mar 14, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

/run-e2e-tests

1 similar comment
@gregwebs
Copy link
Contributor Author

/run-e2e-tests

@gregwebs
Copy link
Contributor Author

/run-e2e-tests

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants