Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stability: add fault-trigger client #326

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Mar 18, 2019

@cwen0 cwen0 added the test/stability stability tests label Mar 18, 2019
httpCli *http.Client
}

// Config defines for schrodinger client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove schrodinger literal?

}

url := util.GenURL(fmt.Sprintf("%s/%s/vm/%s/start", c.cfg.Addr, api.APIPrefix, vmName))
if _, err := c.get(url); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all operations use the HTTP Get method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the operation changes the state, I will replace theGet with Post in a sigle pr.

@cwen0
Copy link
Member Author

cwen0 commented Mar 18, 2019

@weekface PTAL again, thanks!

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0 cwen0 merged commit 07f838d into pingcap:stability Mar 18, 2019
@cwen0 cwen0 deleted the add_fault_client branch March 18, 2019 11:52
weekface pushed a commit to weekface/tidb-operator that referenced this pull request Mar 21, 2019
* stability: add fault-trigger client
tennix pushed a commit that referenced this pull request Mar 21, 2019
* stability: add fault-trigger client
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* add gcs br document

* remove tab

* add br parameter detail

* fix tiny

* remote unused parameter

* modify doc via newest gcs doc

* fix link

* address comment

* address comment

* addrss comment

* modify format

* update toc

* edit several headings

* Update backup-to-gcs-using-br.md

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test/stability stability tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants