Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable admin privilege API for Prometheus #360

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Enable admin privilege API for Prometheus #360

merged 1 commit into from
Apr 4, 2019

Conversation

qiffang
Copy link
Contributor

@qiffang qiffang commented Apr 1, 2019 •
edited
Loading

Just add startup parameter for prometheus for dumping TSDB data

weekface
weekface approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tennix tennix changed the title enable admin privelege for prom Enable admin privilege API for Prometheus Apr 1, 2019
tennix
tennix approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

weekface commented Apr 2, 2019

/run-e2e-tests

1 similar comment
@weekface
Copy link
Contributor

weekface commented Apr 3, 2019

/run-e2e-tests

@weekface weekface merged commit a0594d7 into pingcap:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiffang @weekface @tennix