Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate and ensure setup before e2e-build #375

Merged
merged 4 commits into from
Apr 12, 2019
Merged

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Apr 9, 2019

Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei changed the title Ensure check-setup before build Separate and ensure setup before e2e-build Apr 9, 2019
Signed-off-by: Aylei <rayingecho@gmail.com>
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Aylei <rayingecho@gmail.com>
@weekface
Copy link
Contributor

/run-e2e-tests

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weekface
Copy link
Contributor

@tennix PTAL again.

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit b6dd77e into pingcap:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag v1.0.0-alpha build failed
3 participants