Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidbmonitor add tidb_cluster target label . #3750

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Tidbmonitor add tidb_cluster target label . #3750

merged 2 commits into from
Jan 27, 2021

Conversation

mikechengwei
Copy link
Contributor

@mikechengwei mikechengwei commented Jan 26, 2021 •
edited by DanielZhangQD
Loading

What is changed and how does it work?

Tidbmonitor add tidb_cluster target label to support multiple cluster monitor.

Code changes

  • Has Go code change

Tests

  • Unit test

Release Notes

Add `tidb_cluster` label for the scrape jobs in TidbMonitor to support multiple clusters monitoring

DanielZhangQD
DanielZhangQD approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dragonly
dragonly approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@dragonly dragonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • dragonly

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

zjj2wry
zjj2wry approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@zjj2wry zjj2wry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@zjj2wry: /lgtm is only allowed for the reviewers in list.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@DanielZhangQD DanielZhangQD merged commit 9b6838c into pingcap:master Jan 27, 2021
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jan 27, 2021
@mikechengwei @ti-srebot
cherry pick pingcap#3750 to release-1.1
9784378 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 27, 2021
Merged
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #3753

ti-chi-bot added a commit that referenced this pull request Jan 27, 2021
@ti-srebot @mikechengwei @ti-chi-bot
Tidbmonitor add tidb_cluster target label . (#3750) (#3753)
38fbc12 
* cherry pick #3750 to release-1.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* fix conflict

Co-authored-by: Mike <842725815@qq.com>
Co-authored-by: BinChen <binchinsmail@gmail.com>
Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@zjj2wry zjj2wry zjj2wry approved these changes

@dragonly dragonly dragonly approved these changes

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

@qiffang qiffang Awaiting requested review from qiffang

Assignees
No one assigned
Labels
needs-cherry-pick-1.1 status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikechengwei @ti-chi-bot @ti-srebot @dragonly @zjj2wry @DanielZhangQD