Improve workflow in docs/google-kubernetes-tutorial.md #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aylei
reviewed
Apr 16, 2019
cofyc
force-pushed
the
gke-tutorial
branch
2 times, most recently
from
5e69c78
to
64ccbca
Compare
gregwebs
reviewed
Apr 16, 2019
gregwebs
reviewed
Apr 16, 2019
gregwebs
previously approved these changes
Apr 16, 2019
Co-Authored-By: cofyc <cofyc.jackson@gmail.com>
Co-Authored-By: cofyc <cofyc.jackson@gmail.com>
tennix
reviewed
Apr 17, 2019
tennix
reviewed
Apr 17, 2019
tennix
reviewed
Apr 17, 2019
tennix
approved these changes
Apr 17, 2019
|
follow up issue: #404 |
|
FYI @lilin90 |
tennix
approved these changes
Apr 17, 2019
tennix
previously approved these changes
Apr 17, 2019
lilin90
reviewed
Apr 18, 2019
Co-Authored-By: cofyc <cofyc.jackson@gmail.com>
Co-Authored-By: cofyc <cofyc.jackson@gmail.com>
|
/run-e2e-tests |
tennix
approved these changes
Apr 19, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* operator offline installation * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> * address comment * address comment * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl create service account tiller --namespace kube-systembecause tiller service account yaml has been written into tiller-rbac.yamluse absolute path(bad idea, because the user may clone tidb-operator.git into another directory when they try the tutorial again)$HOME/tidb-operator, so user can paste and run commands under any directorykubectl run ...is removed because it's not a reliable way to access kubernetes service (e.g. when resources are not deleted, user need to clean up manually)svc/demo-tidbinstead ofdemo-tidb-0Test link: https://console.cloud.google.com/cloudshell/open?tutorial=docs/google-kubernetes-tutorial.md&git_repo=https://github.com/cofyc/tidb-operator&cloudshell_git_branch=gke-tutorial