Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade go to 1.18 #4496

Closed
wants to merge 1 commit into from
Closed

Conversation

KanShiori
Copy link
Collaborator

@KanShiori KanShiori commented Mar 25, 2022

What problem does this PR solve?

Close #4474

What is changed and how does it work?

Upgrade go versions to 1.18 in all go.mod.

Upgrade go versions to 1.18 in e2e and git action.

Correct some scripts to support go 1.18.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #4496 (1afa7bb) into master (f208a0f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4496      +/-   ##
==========================================
- Coverage   62.71%   62.69%   -0.02%     
==========================================
  Files         184      184              
  Lines       19868    19868              
==========================================
- Hits        12460    12457       -3     
- Misses       6274     6276       +2     
- Partials     1134     1135       +1     
Flag Coverage Δ
unittest 62.69% <0.00%> (-0.02%) ⬇️

@@ -1,5 +1,6 @@
run:
timeout: 10m
go: '1.17'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go: '1.17'
# golangci don't support some linter in go 1.18, so now run in go1.17
# When we want to use the feature of go 1.18, we can change it.
go: '1.17'

@ti-chi-bot
Copy link
Member

@KanShiori: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@KanShiori KanShiori closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade golang version to 1.18
4 participants