-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade go to 1.18 #4496
[WIP] Upgrade go to 1.18 #4496
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4496 +/- ##
==========================================
- Coverage 62.71% 62.69% -0.02%
==========================================
Files 184 184
Lines 19868 19868
==========================================
- Hits 12460 12457 -3
- Misses 6274 6276 +2
- Partials 1134 1135 +1
|
@@ -1,5 +1,6 @@ | |||
run: | |||
timeout: 10m | |||
go: '1.17' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go: '1.17' | |
# golangci don't support some linter in go 1.18, so now run in go1.17 | |
# When we want to use the feature of go 1.18, we can change it. | |
go: '1.17' |
@KanShiori: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Close #4474
What is changed and how does it work?
Upgrade go versions to 1.18 in all go.mod.
Upgrade go versions to 1.18 in e2e and git action.
Correct some scripts to support go 1.18.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.