Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error in the log when no pd member fails #4608

Merged
merged 8 commits into from
Aug 2, 2022
Merged

fix: error in the log when no pd member fails #4608

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f7a0390
fix: error in the log when no pd member fails
hoyhbx Jun 30, 2022
520879f
fix: error log for disabling PD failover
hoyhbx Jul 5, 2022
3242ab7
Merge branch 'master' into FixErrorLog
KanShiori Jul 8, 2022
4ed140f
recover failover pods if MaxFailoverCount=0
hoyhbx Jul 22, 2022
41e01f8
Merge branch 'FixErrorLog' of github.com:hoyhbx/tidb-operator into Fi…
hoyhbx Jul 22, 2022
1894fe7
Merge branch 'master' into FixErrorLog
DanielZhangQD Jul 25, 2022
31e3ffd
Update pkg/manager/member/pd_member_manager.go
DanielZhangQD Aug 2, 2022
9b906a5
Merge branch 'master' into FixErrorLog
DanielZhangQD Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/manager/member/pd_member_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ func (m *pdMemberManager) syncPDStatefulSetForTidbCluster(tc *v1alpha1.TidbClust
return err
}

if m.deps.CLIConfig.AutoFailover {
if m.deps.CLIConfig.AutoFailover && tc.Spec.PD.MaxFailoverCount != nil && *tc.Spec.PD.MaxFailoverCount > 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if failover occurs and set the max failover count to 0?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can not arrive the Recover func?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failover Pods will not be scaled in and the user needs to remove the failure member manually in the status.pd then the failover Pods will be scaled in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoyhbx After checking the logic of the other component, I think @KanShiori 's above comment is reasonable, we should be able to recover the previous failover Pods even if we set MaxFailoverCount to 0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the check in L244?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I have changed it. @DanielZhangQD

if m.shouldRecover(tc) {
m.failover.Recover(tc)
} else if tc.PDAllPodsStarted() && !tc.PDAllMembersReady() || tc.PDAutoFailovering() {
Expand Down