Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go to 1.16 (#4706) #4738

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Oct 10, 2022

cherry-pick #4706 to release-1.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb-operator repo:
git pr https://github.com/pingcap/tidb-operator/pull/4738

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb-operator.git pr/4738:release-1.3-89faa4d976e0

What problem does this PR solve?

What is changed and how does it work?

Upgrade go versions to 1.16 in all go.mod.

Upgrade go versions to 1.16 in e2e

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

@KanShiori you're already a collaborator in bot's repo.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #4738 (c39e8c7) into release-1.3 (922e517) will increase coverage by 6.55%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.3    #4738      +/-   ##
===============================================
+ Coverage        62.37%   68.92%   +6.55%     
===============================================
  Files              186      190       +4     
  Lines            20869    23340    +2471     
===============================================
+ Hits             13016    16087    +3071     
+ Misses            6638     6011     -627     
- Partials          1215     1242      +27     
Flag Coverage Δ
e2e 48.21% <ø> (?)
unittest 62.34% <ø> (-0.03%) ⬇️

@liubog2008
Copy link
Member

/test pull-e2e-kind

@liubog2008
Copy link
Member

/test pull-e2e-kind-serial

@liubog2008
Copy link
Member

/test pull-e2e-kind

@KanShiori KanShiori closed this Oct 10, 2022
@csuzhangxc csuzhangxc reopened this Feb 10, 2023
@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

@KanShiori
Copy link
Collaborator

/test pull-e2e-kind-serial

@KanShiori
Copy link
Collaborator

/test pull-e2e-kind

7 similar comments
@KanShiori
Copy link
Collaborator

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc csuzhangxc merged commit e1ad97d into pingcap:release-1.3 Feb 14, 2023
@csuzhangxc csuzhangxc deleted the release-1.3-89faa4d976e0 branch February 14, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants