Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/aliyun: update aliyun deploy docs after testing #474

Merged
merged 6 commits into from
May 10, 2019

Conversation

AstroProfundis
Copy link
Contributor

  • Add some notes
  • Add output sample
  • Adjust formatting and some command samples
  • Update requirements

What problem does this PR solve?

Testing current documentation of deploying TiDB Operator on Aliyun with Terraform and keep it up to date.

What is changed and how it works?

  • Tested all instructions in the Aliyun installation documentation on a VM with latest ArchLinux, updated them to fit testing results and added some detailed notes.
  • Renamed the folder "alicloud" to "aliyun" and added an index in the docs folder to point to the full README.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has documents change

Side effects

  • N/A

Related changes

- [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl) >= 1.12
- [helm](https://github.com/helm/helm/blob/master/docs/install.md#installing-the-helm-client) >= 2.9.1
- [helm](https://github.com/helm/helm/blob/master/docs/install.md#installing-the-helm-client) >= 2.9.1 且 <= 2.11.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the maximum version required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatible with tiller version.
ACK has 2.11.0 pre-installed and the latest helm version supported is 2.11.0 according to the document

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 849fec9 into pingcap:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants