Support updating configuraion on the fly #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
2 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
…ration check instead Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
weekface
reviewed
May 14, 2019
weekface
reviewed
May 14, 2019
weekface
reviewed
May 14, 2019
Co-Authored-By: weekface <weekface@gmail.com>
|
/run-e2e-test |
Good idea, yes I think this should be cherry-picked to the 1.0 release |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
|
/run-e2e-tests |
|
I've introduced the logLevel configuration parameter to validate the rolling-update of PD, PTAL @xiaojingchen @weekface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #225
What is changed and how it works?
At the server side, A set of special annotations are introduced, if these annotations present, the PD/TiKV/TiDB statefulset will use the annotation to concat configmap name.
At the client side, if feature gate
EnableConfigMapRolloutenabled, the client will generate SHA256 digest for configmap data and append the digest in configmap name, while keep the annotations mentioned above in sync.After a configuration change, the digest changed so the configmap name and annotations changed, the statefulsets will use the new configmap name due to the annotation change, a rolling-update will performed consequently.
Check List
Tests
The stability test case will be more complicated (which may include mis-configuring scenario) and need more discussion, which will be tracked in another issue.
Code changes
Release Note
Signed-off-by: Aylei rayingecho@gmail.com