fix: adapt to new tiproxy #4821
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
| @@ -1132,7 +1132,7 @@ outer: | |||
| } | |||
|
|
|||
| if zoneLabel == "" { | |||
| klog.Infof("zone labels not found in pd location-labels %v, skip set labels", config.Replication.LocationLabels) | |||
| klog.V(4).Infof("zone labels not found in pd location-labels %v, skip set labels", config.Replication.LocationLabels) | |||
| @@ -206,7 +170,7 @@ security: | |||
| }) | |||
| } | |||
|
|
|||
| klog.Info("get tiproxy in use config map name: ", inUseName) | |||
| klog.V(4).Info("get tiproxy in use config map name: ", inUseName) | |||
| @@ -66,7 +71,9 @@ func (p VolumePhase) String() string { | |||
|
|
|||
| func (p *podVolModifier) getVolumePhase(vol *ActualVolume) VolumePhase { | |||
| if err := p.validate(vol); err != nil { | |||
| klog.Warningf("volume %s/%s modification is not allowed: %v", vol.PVC.Namespace, vol.PVC.Name, err) | |||
| if !errors.Is(err, ErrChangeDefaultStorageClass) { | |||
There was a problem hiding this comment.
Increased verbosity: PD defaults to the default class, and it will report this useless warning all the time.
| @@ -323,7 +323,7 @@ function hack::ensure_go117() { | |||
| patch -d $ROOT -NRp1 -i $ROOT/hack/go117_1.patch -r .rej --no-backup-if-mismatch || true | |||
| patch -d $ROOT -NRp1 -i $ROOT/hack/go117_2.patch -r .rej --no-backup-if-mismatch || true | |||
| patch -d $ROOT -NRp1 -i $ROOT/hack/go117_3.patch -r .rej --no-backup-if-mismatch || true | |||
| rm -rf .rej | |||
| rm -rf .rej .rej.orig | |||
There was a problem hiding this comment.
In some rare cases, .rej.orig will be created.
Signed-off-by: xhe <xw897002528@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4821 +/- ##
==========================================
+ Coverage 59.96% 68.64% +8.67%
==========================================
Files 224 228 +4
Lines 25318 28300 +2982
==========================================
+ Hits 15183 19426 +4243
+ Misses 8707 7429 -1278
- Partials 1428 1445 +17
|
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
|
/test pull-e2e-kind-br |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 3bf2765
|
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Ref pingcap/tiproxy#161. For convenient, tiproxy has changed its config format to TOML.
What is changed and how does it work?
Proxy *ProxyServerOnlineconfig inSpec/Status. Instead,*GenericConfigis used.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.