-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb status add gethealth info #4844
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4844 +/- ##
==========================================
+ Coverage 59.39% 64.77% +5.38%
==========================================
Files 226 230 +4
Lines 25622 28698 +3076
==========================================
+ Hits 15218 18590 +3372
+ Misses 8957 8581 -376
- Partials 1447 1527 +80
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok to return err in syncTidbClusterStatus
the issue is GetHealth()
DO NOT return the error and also DO NOT log the error when getBodyOk
return the error(so we lost this error), so if something makes it keep failing to request the status API, we do not know what happens.
The original issue is /status
keeps blocking(caused by some bug of the pd version), not returning a response. I can not see any log or other thinks about this, and I need to kubectl exec ..
into the pod the request the status API to make sure that this keeps not health in the tc status.
…perator into optimize_health_info
Ok, I modified the code from your perspective.
original code is:
|
/run-all-tests |
1 similar comment
/run-all-tests |
newTidbMember := v1alpha1.TiDBMember{ | ||
Name: name, | ||
Health: health, | ||
} | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to keep the err
in _, err = getBodyOK(httpClient, url)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you revert it in a637f81
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Close #4772 .
What is changed and how does it work?
When tidb sync status info, not ignoring error, and adding message field to sync error detail info.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.