Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against latest stable k8s in e2e kind test #4908

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hanlins
Copy link
Contributor

@hanlins hanlins commented Feb 24, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: Hanlin Shi <shihanlin9@gmail.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Hanlin Shi <shihanlin9@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #4908 (1ce2f88) into master (136086c) will increase coverage by 8.58%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4908      +/-   ##
==========================================
+ Coverage   59.44%   68.02%   +8.58%     
==========================================
  Files         227      231       +4     
  Lines       25835    28944    +3109     
==========================================
+ Hits        15358    19690    +4332     
+ Misses       9019     7778    -1241     
- Partials     1458     1476      +18     
Flag Coverage Δ
e2e 52.94% <ø> (?)
unittest 59.44% <ø> (-0.01%) ⬇️

@hanlins hanlins marked this pull request as draft February 24, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants