Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dp: cherry pick dp prs to release-1.4 #4929

Merged
merged 9 commits into from
Mar 11, 2023

Conversation

WizardXiao
Copy link
Contributor

@WizardXiao WizardXiao commented Mar 10, 2023

What problem does this PR solve?

What is changed and how does it work?

cherry-pick:
#4812
#4819
#4883
#4888
#4895
#4904
#4914
#4922
#4925

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


fengou1 and others added 9 commits March 10, 2023 13:30
* init code for test

* just clean before backup data

* delete test code

* import pingcap/errors

* add check version

* remove test code

* add running status check

* add restart condition to clarify logic

* fix status update

* fix ut
…cap#4895)

* init code for test

* just clean before backup data

* delete test code

* import pingcap/errors

* add check version

* remove test code

* add running status check

* add restart condition to clarify logic

* fix status update

* fix ut

* init code

* update crd reference

* fix miss update retry count

* add retry limit as constant

* init runnable code

* refine main controller logic

* add some note

* address some comments

* init e2e test code

* add e2e env to extend backup time

* add e2e env for test

* fix complie

* just test kill pod

* refine logic

* use pkill to kill pod

* fix reconcile

* add kill pod log

* add more log

* add more log

* try kill pod only

* wait and kill running backup pod

* add wait for pod failed

* fix wait pod running

* use killall backup to kill pod

* use pkill -9 backup

* kill pod until pod is failed

* add ps to debug

* connect commands by semicolon

* kill pod by signal 15

* use panic simulate kill pod

* test all kill pod test

* remove useless log

* add original reason of job or pod failure

* rename BackupRetryFailed to BackupRetryTheFailed
* init schedule log backup code

* add run log backup code

* update api

* refine some nodes

* refine cacluate logic

* add ut

* fix make check

* add log backup test

* refine code

* fix notes

* refine function names

* fix conflict
* refine BackoffRetryPolicy time format

* fix some ut
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangLe1321

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@WizardXiao WizardXiao mentioned this pull request Mar 10, 2023
9 tasks
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #4929 (e9d9962) into release-1.4 (dcc38f3) will increase coverage by 7.69%.
The diff coverage is 40.35%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.4    #4929      +/-   ##
===============================================
+ Coverage        59.91%   67.60%   +7.69%     
===============================================
  Files              224      230       +6     
  Lines            25332    29323    +3991     
===============================================
+ Hits             15178    19825    +4647     
+ Misses            8720     7977     -743     
- Partials          1434     1521      +87     
Flag Coverage Δ
e2e 52.25% <26.18%> (?)
unittest 58.83% <27.68%> (-1.08%) ⬇️

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind-basic

1 similar comment
@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind-basic

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-serial

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind-serial

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind-serial

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-serial

2 similar comments
@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-serial

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-serial

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind

@WizardXiao
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-serial

@WizardXiao WizardXiao merged commit 7f4e089 into pingcap:release-1.4 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants