stability cases added: pd replicas 1 and stop tidb-operator #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
| @@ -148,6 +149,23 @@ func main() { | |||
| TiDBTokenLimit: 1000, | |||
| PDLogLevel: "info", | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Why the one pd test in e2e test and stability test is different ? this test may only test deploy TiDB cluster, so I think the e2e test did a lot of extra work.
There was a problem hiding this comment.
in order to cover this issue: #350
|
LGTM |
shuijing198799
previously approved these changes
May 23, 2019
|
/run-e2e-tests |
|
/run-e2e-tests |
tennix
previously approved these changes
May 24, 2019
| - /usr/local/bin/stability-test | ||
| - --config=/etc/tidb-operator-stability/config.yaml | ||
| - --operator-image=pingcap/tidb-operator:v1.0.0-beta.2 | ||
| - --operator-tag=v1.0.0-beta.2 |
There was a problem hiding this comment.
You can define image-repo and image-tag to avoid passing the same version twice.
There was a problem hiding this comment.
the operator-tag is used by git clone to check out the source code.
For example, the image maybe pingcap/tidb-operator:latest and the operator-tag is master.
tests/failover.go
Outdated
| return err | ||
| } | ||
| err = oa.CheckTidbClustersAvailable(clusters) | ||
| if err != nil { |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
@tennix @shuijing198799 PTAL |
shuijing198799
approved these changes
May 27, 2019
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: