-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fed: setup the br-federation-manager #4996
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4996 +/- ##
==========================================
+ Coverage 59.12% 60.19% +1.06%
==========================================
Files 228 247 +19
Lines 26441 30537 +4096
==========================================
+ Hits 15634 18382 +2748
- Misses 9287 10574 +1287
- Partials 1520 1581 +61
|
/cherry-pick release-1.5 |
@BornChanger: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
tidb-admin
namespace should be existing)tidb-admin
namespace should be existing), NOTE: if thename
is changed to another value, do not forget to set it to.Values.brFederationManager.federationKubeconfigSecret
when install the Hem chart laterkubectl apply -f ./manifests/federation-crd.yaml
in the control planekubectl apply -f ./manifests/crd.yaml
in the data planemake br-federation-docker
(and retag fromlocalhost:5000/pingcap/br-federation-manager
to any other tag as you like)kind load docker-image localhost:5000/pingcap/br-federation-manager
./charts/br-federation
) and install the Helm chart withhelm install --namespace tidb-admin br-federation-manager . --set image=${br-federation-image}
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.