Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-operator: update wording and add note #502

Merged
merged 4 commits into from
May 21, 2019
Merged

tidb-operator: update wording and add note #502

merged 4 commits into from
May 21, 2019

Conversation

dcalvin
Copy link
Contributor

@dcalvin dcalvin commented May 20, 2019 •
edited
Loading

What problem does this PR solve?

  • updated some wording and note info as per the Queeny's test on Deploy TiDB in the minikube cluster
    @AstroProfundis @lilin90 PTAL

dcalvin
dcalvin commented May 20, 2019
View reviewed changes
docs/minikube-tutorial.md Show resolved Hide resolved
docs/minikube-tutorial.md Outdated Show resolved Hide resolved
AstroProfundis
AstroProfundis approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilin90
lilin90 approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tennix
tennix approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit 588a37c into pingcap:master May 21, 2019
@AstroProfundis AstroProfundis mentioned this pull request May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@tennix tennix tennix approved these changes

@AstroProfundis AstroProfundis AstroProfundis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcalvin @AstroProfundis @tennix @lilin90