Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs: calc full snapshot size and report backup size for failed backup (#5007) #5130

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5007

What problem does this PR solve?

Closes #4993

What is changed and how does it work?

  1. Backup size attribute of a backup CR is now the expected size after restore instead of the delta.
  2. Backup size will be reported for both successful and failed ebs backup job
  3. No need to recalculate backupsize at clean time

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gozssky for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu July 3, 2023 08:31
@ti-chi-bot ti-chi-bot bot added the size/L label Jul 3, 2023
@BornChanger
Copy link
Contributor

/cherry-pick-invite @BornChanger

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

@BornChanger: The label(s) /@bornchanger cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick-invite @BornChanger

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

@BornChanger Please accept the invitation then you can push to the cherry-pick pull requests.
Comment with "/cherry-pick-invite" if the invitation is expired.
https://github.com/ti-chi-bot/tidb-operator/invitations

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger BornChanger closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants