Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fed backup schedule (#5036) #5137

Merged
merged 20 commits into from
Jul 4, 2023
Merged

Fed backup schedule (#5036) #5137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
714e1c3
br: implement federation volume backup controller
WangLe1321 May 15, 2023
5303871
br: update backup member to status
WangLe1321 May 22, 2023
b10074f
*: support ebs backup schedule
BornChanger May 30, 2023
48ad800
*: polish code and make ut pass
BornChanger Jun 13, 2023
2d9f8f6
*: fix license header format
BornChanger Jun 13, 2023
c4b925b
*: clean case
BornChanger Jun 14, 2023
2fcb696
*: add resilence code
BornChanger Jun 15, 2023
e7ced9b
*: polish code
BornChanger Jun 16, 2023
70925ee
*: Only GC complete or failed vbk
BornChanger Jun 20, 2023
c521a0f
*: fix ut cases
BornChanger Jun 20, 2023
f55ca78
*: fix compiler warning
BornChanger Jun 21, 2023
3c40f52
*: code format
BornChanger Jun 21, 2023
d1cbf43
*: code format
BornChanger Jun 21, 2023
4507dc4
*: prompt library version
BornChanger Jun 21, 2023
352a797
*: revert unnecessary go.mod change
BornChanger Jun 21, 2023
a1df80d
*: fix go mod
BornChanger Jun 24, 2023
beb4fe6
*: fix lint error
BornChanger Jun 25, 2023
9303364
*: address review comments
BornChanger Jun 25, 2023
129615b
*: revert go.mod
BornChanger Jun 25, 2023
1231bf6
*: fix unit test case
BornChanger Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/api-references/docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,6 @@ BackupSpec
</em>
</td>
<td>
<em>(Optional)</em>
<p>BackupTemplate is the specification of the backup structure to get scheduled.</p>
</td>
</tr>
Expand All @@ -592,6 +591,7 @@ BackupSpec
</em>
</td>
<td>
<em>(Optional)</em>
<p>LogBackupTemplate is the specification of the log backup structure to get scheduled.</p>
</td>
</tr>
Expand Down Expand Up @@ -3708,7 +3708,6 @@ BackupSpec
</em>
</td>
<td>
<em>(Optional)</em>
<p>BackupTemplate is the specification of the backup structure to get scheduled.</p>
</td>
</tr>
Expand All @@ -3722,6 +3721,7 @@ BackupSpec
</em>
</td>
<td>
<em>(Optional)</em>
<p>LogBackupTemplate is the specification of the log backup structure to get scheduled.</p>
</td>
</tr>
Expand Down
181 changes: 180 additions & 1 deletion docs/api-references/federation-docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,66 @@ VolumeBackupScheduleSpec
<br/>
<br/>
<table>
<tr>
<td>
<code>schedule</code></br>
<em>
string
</em>
</td>
<td>
<p>Schedule specifies the cron string used for backup scheduling.</p>
</td>
</tr>
<tr>
<td>
<code>pause</code></br>
<em>
bool
</em>
</td>
<td>
<p>Pause means paused backupSchedule</p>
</td>
</tr>
<tr>
<td>
<code>maxBackups</code></br>
<em>
int32
</em>
</td>
<td>
<p>MaxBackups is to specify how many backups we want to keep
0 is magic number to indicate un-limited backups.
if MaxBackups and MaxReservedTime are set at the same time, MaxReservedTime is preferred
and MaxBackups is ignored.</p>
</td>
</tr>
<tr>
<td>
<code>maxReservedTime</code></br>
<em>
string
</em>
</td>
<td>
<p>MaxReservedTime is to specify how long backups we want to keep.</p>
</td>
</tr>
<tr>
<td>
<code>backupTemplate</code></br>
<em>
<a href="#volumebackupspec">
VolumeBackupSpec
</a>
</em>
</td>
<td>
<p>BackupTemplate is the specification of the volume backup structure to get scheduled.</p>
</td>
</tr>
</table>
</td>
</tr>
Expand Down Expand Up @@ -559,6 +619,7 @@ github.com/pingcap/tidb-operator/pkg/apis/pingcap/v1alpha1.StorageProvider
<p>
(Members of <code>StorageProvider</code> are embedded into this type.)
</p>
<p>StorageProvider configures where and how backups should be stored.</p>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -738,6 +799,76 @@ string
<p>
<p>VolumeBackupScheduleSpec describes the attributes that a user creates on a volume backup schedule.</p>
</p>
<table>
<thead>
<tr>
<th>Field</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<code>schedule</code></br>
<em>
string
</em>
</td>
<td>
<p>Schedule specifies the cron string used for backup scheduling.</p>
</td>
</tr>
<tr>
<td>
<code>pause</code></br>
<em>
bool
</em>
</td>
<td>
<p>Pause means paused backupSchedule</p>
</td>
</tr>
<tr>
<td>
<code>maxBackups</code></br>
<em>
int32
</em>
</td>
<td>
<p>MaxBackups is to specify how many backups we want to keep
0 is magic number to indicate un-limited backups.
if MaxBackups and MaxReservedTime are set at the same time, MaxReservedTime is preferred
and MaxBackups is ignored.</p>
</td>
</tr>
<tr>
<td>
<code>maxReservedTime</code></br>
<em>
string
</em>
</td>
<td>
<p>MaxReservedTime is to specify how long backups we want to keep.</p>
</td>
</tr>
<tr>
<td>
<code>backupTemplate</code></br>
<em>
<a href="#volumebackupspec">
VolumeBackupSpec
</a>
</em>
</td>
<td>
<p>BackupTemplate is the specification of the volume backup structure to get scheduled.</p>
</td>
</tr>
</tbody>
</table>
<h3 id="volumebackupschedulestatus">VolumeBackupScheduleStatus</h3>
<p>
(<em>Appears on:</em>
Expand All @@ -746,10 +877,58 @@ string
<p>
<p>VolumeBackupScheduleStatus represents the current status of a volume backup schedule.</p>
</p>
<table>
<thead>
<tr>
<th>Field</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<code>lastBackup</code></br>
<em>
string
</em>
</td>
<td>
<p>LastBackup represents the last backup.</p>
</td>
</tr>
<tr>
<td>
<code>lastBackupTime</code></br>
<em>
<a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#time-v1-meta">
Kubernetes meta/v1.Time
</a>
</em>
</td>
<td>
<p>LastBackupTime represents the last time the backup was successfully created.</p>
</td>
</tr>
<tr>
<td>
<code>allBackupCleanTime</code></br>
<em>
<a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#time-v1-meta">
Kubernetes meta/v1.Time
</a>
</em>
</td>
<td>
<p>AllBackupCleanTime represents the time when all backup entries are cleaned up</p>
</td>
</tr>
</tbody>
</table>
<h3 id="volumebackupspec">VolumeBackupSpec</h3>
<p>
(<em>Appears on:</em>
<a href="#volumebackup">VolumeBackup</a>)
<a href="#volumebackup">VolumeBackup</a>,
<a href="#volumebackupschedulespec">VolumeBackupScheduleSpec</a>)
</p>
<p>
<p>VolumeBackupSpec describes the attributes that a user creates on a volume backup.</p>
Expand Down
6 changes: 5 additions & 1 deletion manifests/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,6 +1554,10 @@ spec:
jsonPath: .spec.maxBackups
name: MaxBackups
type: integer
- description: How long backups we want to keep
jsonPath: .spec.maxReservedTime
name: MaxReservedTime
type: string
- description: The last backup CR name
jsonPath: .status.lastBackup
name: LastBackup
Expand Down Expand Up @@ -4232,7 +4236,7 @@ spec:
storageSize:
type: string
required:
- logBackupTemplate
- backupTemplate
- schedule
type: object
status:
Expand Down
Loading