Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: make LogBackupTemplate optional #5190

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

Ehco1996
Copy link
Contributor

@Ehco1996 Ehco1996 commented Jul 21, 2023

What problem does this PR solve?

ref #4955

What is changed and how does it work?

as title, this already fixed in #5137 for master, so we just need fix this for release-1.4 branch

Code changes

make BackupScheduleSpec.LogBackupTemplate optional on release-1.4

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

none

@ti-chi-bot ti-chi-bot bot requested review from KanShiori and shonge July 21, 2023 03:48
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ehco1996. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S label Jul 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #5190 (17789bb) into release-1.4 (d3eb028) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.4    #5190      +/-   ##
===============================================
- Coverage        58.90%   58.88%   -0.02%     
===============================================
  Files              227      227              
  Lines            26268    26268              
===============================================
- Hits             15473    15469       -4     
- Misses            9308     9311       +3     
- Partials          1487     1488       +1     
Flag Coverage Δ
unittest 58.88% <ø> (-0.02%) ⬇️

@csuzhangxc csuzhangxc merged commit 8126765 into pingcap:release-1.4 Jul 21, 2023
@csuzhangxc
Copy link
Member

/cherry-pick release-1.4

@ti-chi-bot
Copy link
Member

@csuzhangxc: base branch (release-1.4) needs to differ from target branch (release-1.4).

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 21, 2023

@csuzhangxc: The label(s) /release-1.4 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants