Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: backup manifests related to tidb cluster in EBS backup (#5207) #5215

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5207

What problem does this PR solve?

backup manifests related to tidb cluster in EBS backup

Closes #5116

What is changed and how does it work?

retrieve the objects of TidbMonitor, TidbDashboard, TidbClusterAutoScaler, TidbInitializer, TidbNgMonitoring, filter them by check if their Cluster is equal to tc. Then upload them with tc to the remote storage. The storage path of the manifests {backup-path}/manifests/{namespace}/{kind}/{name}.yaml

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Support backup manifests related to tidb cluster in EBS backup

Signed-off-by: WangLe1321 <wangle1321@163.com>
Signed-off-by: WangLe1321 <wangle1321@163.com>
Signed-off-by: WangLe1321 <wangle1321@163.com>
Signed-off-by: WangLe1321 <wangle1321@163.com>
@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 1, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 14:45:00.707295289 +0000 UTC m=+196584.649643821: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #5215 (1faeef6) into release-1.5 (d6bd886) will decrease coverage by 23.44%.
The diff coverage is 16.35%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.5    #5215       +/-   ##
================================================
- Coverage        57.74%   34.31%   -23.44%     
================================================
  Files              248      218       -30     
  Lines            29441    28684      -757     
================================================
- Hits             17001     9843     -7158     
- Misses           10789    17624     +6835     
+ Partials          1651     1217      -434     
Flag Coverage Δ
e2e 34.31% <16.35%> (?)
unittest ?

@csuzhangxc csuzhangxc merged commit 5422562 into pingcap:release-1.5 Aug 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants