Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: support iam with pod authorization and fix calcSizeLevel invalid (#5220) #5222

Merged
merged 2 commits into from
Aug 3, 2023
Merged

br: support iam with pod authorization and fix calcSizeLevel invalid (#5220) #5222

merged 2 commits into from
Aug 3, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5220

What problem does this PR solve?

  1. support iam with pod authorization for volume backup and volume restore

Closes #5218

  1. fix calcSizeLevel not taking effect problem.

Closes #5219

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@WangLe1321 @ti-chi-bot
br: add annotation to backup and restore in data planes
9f307ed 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321 @ti-chi-bot
br: modify snapSize to public variable
0181501 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2023
Merged
10 tasks
@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge August 3, 2023 04:04
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ehco1996 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #5222 (0181501) into release-1.5 (5422562) will increase coverage by 4.96%.
Report is 1 commits behind head on release-1.5.
The diff coverage is 83.33%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.5    #5222      +/-   ##
===============================================
+ Coverage        57.73%   62.70%   +4.96%     
===============================================
  Files              249      253       +4     
  Lines            29571    33032    +3461     
===============================================
+ Hits             17074    20714    +3640     
+ Misses           10841    10518     -323     
- Partials          1656     1800     +144
Flag Coverage Δ
e2e 38.63% <ø> (?)
unittest 57.74% <83.33%> (+<0.01%) ⬆️

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-tngm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-tngm cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-basic
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-basic, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-basic
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-basic
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-tikv-scale-simultaneously

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc csuzhangxc merged commit 62f179f into pingcap:release-1.5 Aug 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@shonge shonge Awaiting requested review from shonge

Assignees

@csuzhangxc csuzhangxc

Labels
area/ebs-br size/S type/cherry-pick-for-release-1.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @codecov-commenter @csuzhangxc @WangLe1321