Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: keep ports config for TiFlash 7.1.0+ to avoid restarting #5223

Merged
merged 2 commits into from
Aug 4, 2023
Merged

opt: keep ports config for TiFlash 7.1.0+ to avoid restarting #5223

merged 2 commits into from
Aug 4, 2023

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

in #5075, we removed tcp and http ports for tiflash >= 7.1.0.

In this PR, add a tidb.pingcap.com/tiflash-710-keep-ports annotation to avoid restarting when upgrading TiDB Operator for existing TiFlash (>= 7.1.0)

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
    • deploy operator without Remove tcp and http ports for tiflash >= 7.1.0 #5075
    • create a >=v7.1.0 cluster with TiFlash
    • add annotation tidb.pingcap.com/tiflash-710-keep-ports in tc
    • upgrade operator to this PR version
    • observe no TiFlash upgrade
    • remove the annotation
    • observe TiFlash upgrade
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu August 4, 2023 06:26
@ti-chi-bot ti-chi-bot bot added the size/S label Aug 4, 2023
@csuzhangxc
Copy link
Member Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 4, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-04 06:51:24.21407945 +0000 UTC m=+427368.156427980: ☑️ agreed by liubog2008.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 4, 2023
@csuzhangxc
Copy link
Member Author

/test pull-e2e-kind-serial
/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-serial, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-serial
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #5223 (8f9e056) into master (79a770b) will decrease coverage by 31.87%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5223       +/-   ##
===========================================
- Coverage   57.75%   25.88%   -31.87%     
===========================================
  Files         246      209       -37     
  Lines       29479    27858     -1621     
===========================================
- Hits        17025     7211     -9814     
- Misses      10797    19649     +8852     
+ Partials     1657      998      -659
Flag Coverage Δ
e2e 25.88% <100.00%> (?)
unittest ?

@csuzhangxc
Copy link
Member Author

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member Author

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc csuzhangxc enabled auto-merge (squash) August 4, 2023 10:02
@csuzhangxc csuzhangxc merged commit 6cff3fa into pingcap:master Aug 4, 2023
4 of 5 checks passed
@csuzhangxc csuzhangxc deleted the skip-tiflash-restart branch August 4, 2023 10:02
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5225.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 4, 2023
Merged
10 tasks
csuzhangxc added a commit that referenced this pull request Aug 4, 2023
@ti-chi-bot @csuzhangxc
opt: keep ports config for TiFlash 7.1.0+ to avoid restarting (#5223) (…
4d31255 
…#5225)

Co-authored-by: csuzhangxc <csuzhangxc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liubog2008 liubog2008 liubog2008 approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csuzhangxc @ti-chi-bot @codecov-commenter @liubog2008