-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow porting labels when initiating backup/restore member #5237
allow porting labels when initiating backup/restore member #5237
Conversation
olivia_chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5237 +/- ##
==========================================
+ Coverage 57.76% 60.94% +3.17%
==========================================
Files 246 249 +3
Lines 29479 32817 +3338
==========================================
+ Hits 17029 19999 +2970
- Misses 10795 11038 +243
- Partials 1655 1780 +125
|
@oliviachenairbnb Please sign the CLA form. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-e2e-kind |
@oliviachenairbnb: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@oliviachenairbnb: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/cherry-pick release-1.5 |
@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@BornChanger: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
@oliviachenairbnb: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
iam role cannot be used during backup process
What is changed and how does it work?
allow porting labels when initiating backup/restore member
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.