Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify backup path to add root folder #5245

Closed
wants to merge 2 commits into from
Closed

Modify backup path to add root folder #5245

wants to merge 2 commits into from

Conversation

olivia-chen-github
Copy link
Contributor

@olivia-chen-github olivia-chen-github commented Aug 15, 2023

What problem does this PR solve?

currently ebs backup for multi az cluster will create backup path
s3://{bucket_name}/prefix-k8s-cluster. so backups for each k8s cluster don't have a root folder.

for volumebackupschedule, we saw external storage backup path folder name starting with hyphen
shared-iam/sched1/-2023-08-10t23-10-00-m-tidb-test-d-ea1-us/
shared-iam/sched1/-2023-08-10t23-10-00-m-tidb-test-e-ea1-us/
shared-iam/sched1/-2023-08-10t23-10-00-m-tidb-test-f-ea1-us/

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Adding a new level of folder in backup path.
e.g.
volumeBackup vb1 creates folder
s3://{bucket_name}/{backup_namespace}/vb1-k8s-cluster1,
s3://{bucket_name}/{backup_namespace}/vb1-k8s-cluster2 and
s3://{bucket_name}/{backup_namespace}/vb1-k8s-cluster3.

backup path after this change will be like
s3://{bucket_name}/{backup_namespace}/vb1/k8s-cluster1,
s3://{bucket_name}/{backup_namespace}/vb1/k8s-cluster2,
s3://{bucket_name}/{backup_namespace}/vb1/k8s-cluster3

for volumebackupschedule, this code change will remove the hyphen

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Reviewers: @WangLe1321 @BornChanger

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #5245 (695f135) into master (ddc83e6) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5245      +/-   ##
==========================================
- Coverage   57.76%   57.76%   -0.01%     
==========================================
  Files         246      246              
  Lines       29479    29479              
==========================================
- Hits        17029    17028       -1     
- Misses      10795    10796       +1     
  Partials     1655     1655              
Flag Coverage Δ
unittest 57.76% <100.00%> (-0.01%) ⬇️

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olivia-chen-github olivia-chen-github closed this by deleting the head repository Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants