Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs-warmup: added exec mode for warmup-steps.sh #5258

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

YuJuncen
Copy link
Contributor

What problem does this PR solve?

The current warmup_steps.sh isn't executable in the ebs-warmup container, which forces the caller to change the permission firstly for it.

What is changed and how does it work?

This added execution permission for the entry script.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
image - [ ] No code

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge August 21, 2023 06:04
@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #5258 (24e67fa) into master (cb6b246) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5258   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files         246      246           
  Lines       29806    29806           
=======================================
+ Hits        17067    17069    +2     
+ Misses      11078    11077    -1     
+ Partials     1661     1660    -1     
Flag Coverage Δ
unittest 57.26% <ø> (+<0.01%) ⬆️

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BornChanger,WangLe1321]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 21, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

@YuJuncen: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-21 06:06:04.732050865 +0000 UTC m=+1129529.281066854: ☑️ agreed by BornChanger.
  • 2023-08-22 08:15:21.291937875 +0000 UTC m=+1223685.840953861: ✖️🔁 reset by ti-chi-bot[bot].

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

New changes are detected. LGTM label has been removed.

@csuzhangxc csuzhangxc merged commit bc7d36a into pingcap:master Aug 22, 2023
5 of 6 checks passed
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5261.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants