-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs-warmup: added exec mode for warmup-steps.sh #5258
Conversation
Signed-off-by: hillium <yujuncen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5258 +/- ##
=======================================
Coverage 57.26% 57.26%
=======================================
Files 246 246
Lines 29806 29806
=======================================
+ Hits 17067 17069 +2
+ Misses 11078 11077 -1
+ Partials 1661 1660 -1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherry-pick release-1.5 |
@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@BornChanger: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/retest |
@YuJuncen: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
The current
warmup_steps.sh
isn't executable in theebs-warmup
container, which forces the caller to change the permission firstly for it.What is changed and how does it work?
This added execution permission for the entry script.
Code changes
Tests
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.