Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: print out the elapsed time for each snapshot size calculation #5263

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Aug 23, 2023

What problem does this PR solve?

Closes #5264

What is changed and how does it work?

This pr will directly print the elapsed time of snapshot size calculation in backup pod log.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BornChanger
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@503c082). Click here to learn what that means.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5263   +/-   ##
=========================================
  Coverage          ?   57.25%           
=========================================
  Files             ?      247           
  Lines             ?    29872           
  Branches          ?        0           
=========================================
  Hits              ?    17103           
  Misses            ?    11105           
  Partials          ?     1664           
Flag Coverage Δ
unittest 57.25% <0.00%> (?)

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 23, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-23 10:04:27.370804071 +0000 UTC m=+1316631.919820055: ☑️ agreed by WangLe1321.
  • 2023-08-23 12:55:22.539542288 +0000 UTC m=+1326887.088558275: ✖️🔁 reset by ti-chi-bot[bot].

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

New changes are detected. LGTM label has been removed.

@BornChanger
Copy link
Contributor Author

/retest

@csuzhangxc csuzhangxc merged commit af4c23a into pingcap:master Aug 23, 2023
5 of 13 checks passed
@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5267.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Aug 24, 2023
…#5263) (#5267)

Signed-off-by: BornChanger <dawn_catcher@126.com>
Co-authored-by: BornChanger <dawn_catcher@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: record the elapsed time for snapshot size calculation in backup pod log
5 participants