deploy/aws: split public and private subnets when using existing vpc #530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This should close #514
What is changed and how it works?
subnets
toprivate_subnet_ids
andpublic_subnet_ids
, to correctly put resources into different network.cluster_name
to helm release name, making pod names uniqueCheck List
Tests
Code changes
Side effects
terraform
with new code to manage an cluster deployed by old versions.Related changes
Does this PR introduce a user-facing change?: