Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: validate volume number for ebs snapshot restore (#5292) #5310

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5292

What problem does this PR solve?

Close #5287

What is changed and how does it work?

We will check if restore TC has the same volume number as the upstream cluster.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-5292-to-release-1.5 branch from f02d126 to b28bb9c Compare September 27, 2023 09:40
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #5310 (f02d126) into release-1.5 (4d39487) will increase coverage by 0.25%.
Report is 1 commits behind head on release-1.5.
The diff coverage is 90.32%.

❗ Current head f02d126 differs from pull request most recent head b28bb9c. Consider uploading reports for the commit b28bb9c to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5310      +/-   ##
===============================================
+ Coverage        57.48%   57.73%   +0.25%     
===============================================
  Files              254      254              
  Lines            30610    30797     +187     
===============================================
+ Hits             17596    17782     +186     
+ Misses           11283    11281       -2     
- Partials          1731     1734       +3     
Flag Coverage Δ
unittest 57.73% <90.32%> (+0.25%) ⬆️

@csuzhangxc csuzhangxc merged commit 52e1c7c into pingcap:release-1.5 Sep 27, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants