Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get TS and use it before full backup using mydumper #534

Merged
merged 19 commits into from
Jun 5, 2019

Conversation

weekface
Copy link
Contributor

@weekface weekface commented May 29, 2019

What problem does this PR solve?

This pr fixes: #533 and closes: #540

  • remove --chunk-filesize option
  • set --verbose to 3 (info)
  • fix stability tests about binlog backup
  • get TS before backup

The mydumper output when we change --verbose to 3:

** Message: Server version reported as: 5.7.25-TiDB-v3.0.0-rc.1
** Message: Connected to a TiDB server
** Message: Skipping locks because of TiDB
** Message: Set to tidb_snapshot '408711625696608257'
** Message: Started dump at: 2019-05-29 06:25:37
** Message: Written master status
** Message: Thread 1 connected using MySQL connection ID 28
** Message: Thread 1 set to tidb_snapshot '408711625696608257'
** Message: Thread 2 connected using MySQL connection ID 60
** Message: Thread 2 set to tidb_snapshot '408711625696608257'
** Message: Thread 3 connected using MySQL connection ID 29
** Message: Thread 3 set to tidb_snapshot '408711625696608257'
** Message: Thread 4 connected using MySQL connection ID 61
** Message: Thread 4 set to tidb_snapshot '408711625696608257'
** Message: Thread 3 dumping data for `mysql`.`GLOBAL_VARIABLES`
** Message: Non-InnoDB dump complete, unlocking tables
** Message: Thread 2 dumping data for `mysql`.`columns_priv`
** Message: Thread 1 dumping data for `mysql`.`bind_info`
** Message: Thread 4 dumping data for `mysql`.`db`
** Message: Empty table mysql.bind_info
** Message: Thread 1 dumping data for `mysql`.`default_roles`
** Message: Empty table mysql.columns_priv
** Message: Thread 2 dumping data for `mysql`.`gc_delete_range`
** Message: Empty table mysql.db
** Message: Thread 4 dumping data for `mysql`.`gc_delete_range_done`
** Message: Thread 3 dumping data for `mysql`.`help_topic`
** Message: Empty table mysql.gc_delete_range
** Message: Thread 2 dumping data for `mysql`.`role_edges`
** Message: Empty table mysql.gc_delete_range_done
** Message: Thread 4 dumping data for `mysql`.`stats_buckets`
** Message: Empty table mysql.help_topic
** Message: Thread 3 dumping data for `mysql`.`stats_feedback`
** Message: Empty table mysql.role_edges
** Message: Thread 2 dumping data for `mysql`.`stats_histograms`
** Message: Empty table mysql.stats_feedback
** Message: Thread 3 dumping data for `mysql`.`stats_meta`
** Message: Thread 3 dumping data for `mysql`.`stats_top_n`
** Message: Empty table mysql.stats_top_n
** Message: Thread 3 dumping data for `mysql`.`tables_priv`
** Message: Thread 2 dumping data for `mysql`.`tidb`
** Message: Thread 2 dumping data for `mysql`.`user`
** Message: Thread 2 dumping data for `test`.`block_writer`
** Message: Thread 4 dumping data for `test`.`block_writer1`
** Message: Empty table mysql.default_roles
** Message: Thread 1 dumping data for `test`.`block_writer10`
** Message: Thread 4 dumping data for `test`.`block_writer11`
** Message: Thread 2 dumping data for `test`.`block_writer12`
** Message: Thread 1 dumping data for `test`.`block_writer13`
** Message: Empty table mysql.tables_priv
** Message: Thread 3 dumping data for `test`.`block_writer14`
** Message: Thread 4 dumping data for `test`.`block_writer15`
** Message: Thread 2 dumping data for `test`.`block_writer16`
** Message: Thread 1 dumping data for `test`.`block_writer17`
** Message: Thread 3 dumping data for `test`.`block_writer18`
** Message: Thread 4 dumping data for `test`.`block_writer19`
** Message: Thread 4 dumping data for `test`.`block_writer2`
** Message: Thread 3 dumping data for `test`.`block_writer20`
** Message: Thread 2 dumping data for `test`.`block_writer21`
** Message: Thread 4 dumping data for `test`.`block_writer22`
** Message: Thread 2 dumping data for `test`.`block_writer23`
** Message: Thread 3 dumping data for `test`.`block_writer24`
** Message: Thread 1 dumping data for `test`.`block_writer25`
** Message: Thread 4 dumping data for `test`.`block_writer26`
** Message: Thread 3 dumping data for `test`.`block_writer27`
** Message: Thread 2 dumping data for `test`.`block_writer28`
** Message: Thread 1 dumping data for `test`.`block_writer29`
** Message: Thread 4 dumping data for `test`.`block_writer3`
** Message: Thread 3 dumping data for `test`.`block_writer30`
** Message: Thread 2 dumping data for `test`.`block_writer31`
** Message: Thread 1 dumping data for `test`.`block_writer32`
** Message: Thread 4 dumping data for `test`.`block_writer33`
** Message: Thread 2 dumping data for `test`.`block_writer34`
** Message: Thread 4 dumping data for `test`.`block_writer35`
** Message: Thread 3 dumping data for `test`.`block_writer36`
** Message: Thread 2 dumping data for `test`.`block_writer37`
** Message: Thread 4 dumping data for `test`.`block_writer38`
** Message: Thread 1 dumping data for `test`.`block_writer39`
** Message: Thread 3 dumping data for `test`.`block_writer4`
** Message: Thread 2 dumping data for `test`.`block_writer40`
** Message: Thread 4 dumping data for `test`.`block_writer41`
** Message: Thread 1 dumping data for `test`.`block_writer42`
** Message: Thread 3 dumping data for `test`.`block_writer43`
** Message: Thread 2 dumping data for `test`.`block_writer44`
** Message: Thread 4 dumping data for `test`.`block_writer45`
** Message: Thread 1 dumping data for `test`.`block_writer46`
** Message: Thread 2 dumping data for `test`.`block_writer47`
** Message: Thread 4 dumping data for `test`.`block_writer48`
** Message: Thread 3 dumping data for `test`.`block_writer49`
** Message: Thread 2 dumping data for `test`.`block_writer5`
** Message: Thread 4 dumping data for `test`.`block_writer50`
** Message: Thread 1 dumping data for `test`.`block_writer51`
** Message: Thread 3 dumping data for `test`.`block_writer52`
** Message: Thread 2 dumping data for `test`.`block_writer53`
** Message: Thread 2 dumping data for `test`.`block_writer54`
** Message: Thread 3 dumping data for `test`.`block_writer55`
** Message: Thread 4 dumping data for `test`.`block_writer56`
** Message: Thread 3 dumping data for `test`.`block_writer57`
** (mydumper:1): CRITICAL **: Error dumping table (test.block_writer51) data: other error: request to underhook engine failed
** Message: Empty table test.block_writer51
** Message: Thread 1 dumping data for `test`.`block_writer58`
** Message: Thread 2 dumping data for `test`.`block_writer59`
** Message: Thread 4 dumping data for `test`.`block_writer6`
** Message: Thread 3 dumping data for `test`.`block_writer60`
** Message: Thread 1 dumping data for `test`.`block_writer61`
** Message: Thread 2 dumping data for `test`.`block_writer62`
** Message: Thread 4 dumping data for `test`.`block_writer63`
** Message: Thread 3 dumping data for `test`.`block_writer7`
** Message: Thread 1 dumping data for `test`.`block_writer8`
** Message: Thread 1 dumping data for `test`.`block_writer9`
** Message: Thread 2 dumping data for `test`.`testTable`
** Message: Thread 2 dumping schema for `mysql`.`GLOBAL_VARIABLES`
** Message: Thread 2 dumping schema for `mysql`.`bind_info`
** Message: Thread 2 dumping schema for `mysql`.`columns_priv`
** Message: Thread 2 dumping schema for `mysql`.`db`
** Message: Thread 2 dumping schema for `mysql`.`default_roles`
** Message: Thread 2 dumping schema for `mysql`.`gc_delete_range`
** Message: Thread 2 dumping schema for `mysql`.`gc_delete_range_done`
** Message: Thread 2 dumping schema for `mysql`.`help_topic`
** Message: Thread 2 dumping schema for `mysql`.`role_edges`
** Message: Thread 2 dumping schema for `mysql`.`stats_buckets`
** Message: Thread 2 dumping schema for `mysql`.`stats_feedback`
** Message: Thread 2 dumping schema for `mysql`.`stats_histograms`
** Message: Thread 2 dumping schema for `mysql`.`stats_meta`
** Message: Thread 2 dumping schema for `mysql`.`stats_top_n`
** Message: Thread 2 dumping schema for `mysql`.`tables_priv`
** Message: Thread 2 dumping schema for `mysql`.`tidb`
** Message: Thread 2 dumping schema for `mysql`.`user`
** Message: Thread 2 dumping schema for `test`.`block_writer`
** Message: Thread 2 dumping schema for `test`.`block_writer1`
** Message: Thread 2 dumping schema for `test`.`block_writer10`
** Message: Thread 2 dumping schema for `test`.`block_writer11`
** Message: Thread 2 dumping schema for `test`.`block_writer12`
** Message: Thread 2 dumping schema for `test`.`block_writer13`
** Message: Thread 2 dumping schema for `test`.`block_writer14`
** Message: Thread 2 dumping schema for `test`.`block_writer15`
** Message: Thread 2 dumping schema for `test`.`block_writer16`
** Message: Thread 2 dumping schema for `test`.`block_writer17`
** Message: Thread 2 dumping schema for `test`.`block_writer18`
** Message: Thread 2 dumping schema for `test`.`block_writer19`
** Message: Thread 2 dumping schema for `test`.`block_writer2`
** Message: Thread 2 dumping schema for `test`.`block_writer20`
** Message: Thread 2 dumping schema for `test`.`block_writer21`
** Message: Thread 2 dumping schema for `test`.`block_writer22`
** Message: Thread 2 dumping schema for `test`.`block_writer23`
** Message: Thread 2 dumping schema for `test`.`block_writer24`
** Message: Thread 2 dumping schema for `test`.`block_writer25`
** Message: Thread 2 dumping schema for `test`.`block_writer26`
** Message: Thread 2 dumping schema for `test`.`block_writer27`
** Message: Thread 2 dumping schema for `test`.`block_writer28`
** Message: Thread 2 dumping schema for `test`.`block_writer29`
** Message: Thread 2 dumping schema for `test`.`block_writer3`
** Message: Thread 2 dumping schema for `test`.`block_writer30`
** Message: Thread 2 dumping schema for `test`.`block_writer31`
** Message: Thread 2 dumping schema for `test`.`block_writer32`
** Message: Thread 2 dumping schema for `test`.`block_writer33`
** Message: Thread 2 dumping schema for `test`.`block_writer34`
** Message: Thread 2 dumping schema for `test`.`block_writer35`
** Message: Thread 2 dumping schema for `test`.`block_writer36`
** Message: Thread 2 dumping schema for `test`.`block_writer37`
** Message: Thread 2 dumping schema for `test`.`block_writer38`
** Message: Thread 2 dumping schema for `test`.`block_writer39`
** Message: Thread 2 dumping schema for `test`.`block_writer4`
** Message: Thread 2 dumping schema for `test`.`block_writer40`
** Message: Thread 2 dumping schema for `test`.`block_writer41`
** Message: Thread 2 dumping schema for `test`.`block_writer42`
** Message: Thread 2 dumping schema for `test`.`block_writer43`
** Message: Thread 2 dumping schema for `test`.`block_writer44`
** Message: Thread 2 dumping schema for `test`.`block_writer45`
** Message: Thread 2 dumping schema for `test`.`block_writer46`
** Message: Thread 2 dumping schema for `test`.`block_writer47`
** Message: Thread 2 dumping schema for `test`.`block_writer48`
** Message: Thread 2 dumping schema for `test`.`block_writer49`
** Message: Thread 2 dumping schema for `test`.`block_writer5`
** Message: Thread 2 dumping schema for `test`.`block_writer50`
** Message: Thread 2 dumping schema for `test`.`block_writer51`
** Message: Thread 2 dumping schema for `test`.`block_writer52`
** Message: Thread 2 dumping schema for `test`.`block_writer53`
** Message: Thread 2 dumping schema for `test`.`block_writer54`
** Message: Thread 2 dumping schema for `test`.`block_writer55`
** Message: Thread 2 dumping schema for `test`.`block_writer56`
** Message: Thread 2 dumping schema for `test`.`block_writer57`
** Message: Thread 2 dumping schema for `test`.`block_writer58`
** Message: Thread 2 dumping schema for `test`.`block_writer59`
** Message: Thread 2 dumping schema for `test`.`block_writer6`
** Message: Thread 2 dumping schema for `test`.`block_writer60`
** Message: Thread 2 dumping schema for `test`.`block_writer61`
** Message: Thread 2 dumping schema for `test`.`block_writer62`
** Message: Thread 2 dumping schema for `test`.`block_writer63`
** Message: Thread 2 dumping schema for `test`.`block_writer7`
** Message: Thread 2 dumping schema for `test`.`block_writer8`
** Message: Thread 2 dumping schema for `test`.`block_writer9`
** Message: Thread 2 dumping schema for `test`.`testTable`
** Message: Thread 2 shutting down
** Message: Thread 3 shutting down
** Message: Thread 4 shutting down
** Message: Thread 1 shutting down
** Message: Finished dump at: 2019-05-29 06:27:50

What is changed and how it works?

Check List

Tests

  • E2E test
  • Stability test
  • No code

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

get TS and use it before full backup using mydumper

@weekface
Copy link
Contributor Author

/run-e2e-tests

xiaojingchen
xiaojingchen previously approved these changes May 29, 2019
* set --verbose to 3: 0 = silent, 1 = errors, 2 = warnings, 3 = info
@weekface weekface changed the title reduce ad-hoc backup options --chunk-filesize from 100MB to 10MB [DNM] reduce ad-hoc backup options --chunk-filesize from 100MB to 10MB May 29, 2019
@shuijing198799
Copy link
Contributor

LGTM

shuijing198799
shuijing198799 previously approved these changes May 29, 2019
@weekface
Copy link
Contributor Author

/run-e2e-tests

* remove backup initContainers
@weekface weekface changed the title [DNM] reduce ad-hoc backup options --chunk-filesize from 100MB to 10MB [DNM] reduce ad-hoc backup options --chunk-filesize from 100MB to 1MB May 30, 2019
@weekface weekface changed the title [DNM] reduce ad-hoc backup options --chunk-filesize from 100MB to 1MB [DNM] fix stability backup tests May 30, 2019
@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface weekface changed the title [DNM] fix stability backup tests fix stability backup tests May 31, 2019
@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface weekface changed the title fix stability backup tests [DNM] fix stability backup tests Jun 1, 2019
@weekface
Copy link
Contributor Author

weekface commented Jun 3, 2019

/run-e2e-tests

@weekface weekface changed the title [DNM] fix stability backup tests fix stability backup tests Jun 3, 2019
@weekface weekface changed the title fix stability backup tests get TS and use it before full backup using mydumper Jun 3, 2019
@weekface
Copy link
Contributor Author

weekface commented Jun 4, 2019

/run-e2e-tests

@weekface
Copy link
Contributor Author

weekface commented Jun 5, 2019

@xiaojingchen @aylei PTAL

@xiaojingchen
Copy link
Contributor

/run-e2e-test

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

weekface commented Jun 5, 2019

/run-e2e-test

@weekface weekface merged commit ef33ba5 into pingcap:master Jun 5, 2019
@weekface weekface deleted the reduce-chunk-filesize branch June 5, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB Binlog backup not works on stability test Mydumper cause TiKV OOMKilled
4 participants