Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tkctl get cpu info rendering #536

Merged
merged 3 commits into from
May 31, 2019
Merged

Fix tkctl get cpu info rendering #536

merged 3 commits into from
May 31, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented May 30, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Manual test

Related changes

  • Need to cherry-pick to the release branch

@tennix @weekface @xiaojingchen PTAL

Does this PR introduce a user-facing change?:

`tkctl get` can show cpu usage correctly now.

aylei added 2 commits May 30, 2019 10:51
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei added the type/bug Something isn't working label May 30, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a release note please.

@aylei
Copy link
Contributor Author

aylei commented May 30, 2019

/run-e2e-tests

@weekface weekface merged commit 37d6933 into pingcap:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants