Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capabilities and privilege mode for debug container #537

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented May 30, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

close #535

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has documents change

@tennix @onlymellb @weekface @xiaojingchen PTAL

Does this PR introduce a user-facing change?:

Fix capabilities issue for `tkctl debug` command.

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei added type/bug Something isn't working area/doc labels May 30, 2019
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a release note.


### perf (and flame graph)

To use `perf` and the `run_flamegraph.sh` script (which wraps the `perf` tool) properly, you must copy the program from the target container to the same location in the debug container:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a must step for flamegraph?

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 8e8f526 into pingcap:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tkctl cannot use gdb and flamegraph to debug tikv-server
3 participants