Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebs br: make sure backup can be resumed even after being paused for a long time #5464

Merged
merged 4 commits into from
Dec 18, 2023
Merged

ebs br: make sure backup can be resumed even after being paused for a long time #5464

merged 4 commits into from
Dec 18, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Dec 14, 2023 •
edited
Loading

What problem does this PR solve?

Closes #5392

What is changed and how does it work?

Make sure backup can be scheduled even if backup schedule has been paused for a long time.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot ti-chi-bot bot added the size/M label Dec 14, 2023
@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @csuzhangxc

@BornChanger BornChanger changed the title ebs br: make sure backup can be resumed even after being paused for a… ebs br: make sure backup can be resumed even after being paused for a long time Dec 14, 2023
@BornChanger
ebs br: make sure backup can be resumed even after being paused for a…
6adf8d3 
… long time

Signed-off-by: BornChanger <dawn_catcher@126.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023 •
edited
Loading

Codecov Report

Merging #5464 (f95f893) into master (533439c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5464      +/-   ##
==========================================
+ Coverage   61.59%   61.64%   +0.05%     
==========================================
  Files         230      241      +11     
  Lines       29152    32981    +3829     
==========================================
+ Hits        17955    20330    +2375     
- Misses       9430    10779    +1349     
- Partials     1767     1872     +105
Flag Coverage Δ
e2e 21.88% <0.00%> (?)
unittest 61.58% <100.00%> (-0.01%) ⬇️

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
*: fast move forward when too many advance
3c638e3 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 18, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 18, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 18, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-18 09:48:16.842576945 +0000 UTC m=+867987.879803868: ☑️ agreed by WangLe1321.
  • 2023-12-18 10:01:09.554078759 +0000 UTC m=+868760.591305698: ✖️🔁 reset by ti-chi-bot[bot].

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

New changes are detected. LGTM label has been removed.

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc csuzhangxc merged commit 14f5a7e into pingcap:master Dec 18, 2023
6 of 7 checks passed
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5466.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 18, 2023
Merged
10 tasks
csuzhangxc pushed a commit that referenced this pull request Dec 18, 2023
@ti-chi-bot @BornChanger
ebs br: make sure backup can be resumed even after being paused for a…
fb48c8d 
… long time (#5464) (#5466)

Signed-off-by: BornChanger <dawn_catcher@126.com>
Co-authored-by: BornChanger <dawn_catcher@126.com>
@BornChanger BornChanger mentioned this pull request Jan 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangLe1321 WangLe1321 WangLe1321 approved these changes

@howardlau1999 howardlau1999 Awaiting requested review from howardlau1999

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

Assignees
No one assigned
Labels
approved area/ebs-br size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ebs br: volume back schedule fail if the backup schedule is activated after being paused for a long time
5 participants
@BornChanger @codecov-commenter @ti-chi-bot @WangLe1321 @csuzhangxc