Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use staticcheck instead of megacheck #548

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Jun 3, 2019

What problem does this PR solve?

https://github.com/dominikh/go-tools/blob/5a4a2f4a438d01ba03c591f88ef312005a05063b/doc/2019.1.html

At the core of the 2019.1 release lies the grand restructuring of all of the staticcheck tools.
  All of the individual checkers, as well as megacheck, have been merged into a single tool,
  which is simply called staticcheck.

So we use staticcheck instead of megacheck.

This pr fixes: #546

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • Has CI related scripts change

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

@weekface weekface requested review from gregwebs and tennix June 3, 2019 05:44
@weekface
Copy link
Contributor Author

weekface commented Jun 3, 2019

/run-e2e-tests

@weekface weekface merged commit fe13e55 into pingcap:master Jun 3, 2019
@weekface weekface deleted the add-staticcheck branch June 3, 2019 07:43
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retool sync failed
2 participants