-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: set volume backup failed if one data plane failed #5500
br: set volume backup failed if one data plane failed #5500
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5500 +/- ##
==========================================
- Coverage 61.38% 61.37% -0.01%
==========================================
Files 234 234
Lines 29941 29947 +6
==========================================
+ Hits 18378 18379 +1
- Misses 9724 9727 +3
- Partials 1839 1841 +2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
/cherry-pick release-1.5 |
@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Make sure the VolumeBackup is failed after backup initialize failed.
Closes #5499
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.