Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: set volume backup failed if one data plane failed (#5500) #5508

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5500

What problem does this PR solve?

Make sure the VolumeBackup is failed after backup initialize failed.

Closes #5499

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign azurezyq for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BornChanger
Copy link
Contributor

/run-pull-e2e-kind-br

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (570bd3e) 61.64% compared to head (51a6759) 61.94%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5508      +/-   ##
===============================================
+ Coverage        61.64%   61.94%   +0.30%     
===============================================
  Files              228      241      +13     
  Lines            29130    33079    +3949     
===============================================
+ Hits             17956    20492    +2536     
- Misses            9406    10710    +1304     
- Partials          1768     1877     +109     
Flag Coverage Δ
e2e 22.49% <ø> (?)
unittest 61.64% <30.00%> (+<0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit 02e4bd2 into pingcap:release-1.5 Jan 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants