ebs: adjust volume tagging #5525
Conversation
Signed-off-by: BornChanger <dawn_catcher@126.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5525 +/- ##
==========================================
- Coverage 61.38% 59.27% -2.12%
==========================================
Files 234 245 +11
Lines 29961 33822 +3861
==========================================
+ Hits 18391 20047 +1656
- Misses 9737 11871 +2134
- Partials 1833 1904 +71
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/cherry-pick release-1.5 |
|
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| tags[PodNSTagKey] = pv.GetLabels()[label.NamespaceLabelKey] | ||
| if pv.Spec.ClaimRef != nil { | ||
| tags[PvcNameTagKey] = pv.Spec.ClaimRef.Name | ||
| tags[PvcNSTagKey] = pv.Spec.ClaimRef.Namespace |
There was a problem hiding this comment.
The code seems correct But the screenshot in the PR does NOT show the tag "kubernetes.io/created-for/pvc/namespace", but rather shows "snapshot/kubernetes.io/created-for/pvc/namespace".
What problem does this PR solve?
Closes #5506
What is changed and how does it work?
Add pvc name as tag of restored volume
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.