Gke terraform upgrade to 0.12 and fix bastion instance zone to be region agnostic #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlerche
changed the title
|
@yikeke @DanielZhangQD PTAL |
Good job! And please remove the note accordingly under the "Destroy" section in the deploy/gcp/README.md file, thanks! |
jlerche
force-pushed
the
gke_terraform_region_agnostic_upgrade_tf_0-12
branch
from
cd74920
to
954ad0b
Compare
aylei
reviewed
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR fixes #522 as well as upgrading the GCP terraform script to 0.12 compatibility. It will break backwards compatibility, but terraform will not run until upgraded
What is changed and how it works?
gcloud compute regions describe name-of-regionto see what zones are available in the region, and grabs the first one in the resultterraform destroyit would frequently abort because GCP does not allow deleting simultaneous node pools. The user would then have to re-run the command. This no longer happens, the downside is thatterraform applywill run a little slower as the node pools are now created and destroyed sequentially.Check List
Tests
terraform applyterraform destroyCode changes
Side effects
Related changes
Does this PR introduce a user-facing change?: