pdms: remove shutdown component and add test for scaler&upgrader #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuSharp
force-pushed
the
add_scaler_and_upgrader_test
branch
from
2989d69 to
e753190
Compare
|
/run-all-tests |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5554 +/- ##
==========================================
+ Coverage 61.32% 61.47% +0.15%
==========================================
Files 235 235
Lines 30083 30097 +14
==========================================
+ Hits 18449 18503 +54
+ Misses 9793 9740 -53
- Partials 1841 1854 +13
|
|
/run-pull-e2e-kind-serial |
|
/run-pull-e2e-kind-tngm |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp
changed the title
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@csuzhangxc friendly ping :) |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
csuzhangxc
approved these changes
Feb 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the bug that modifing tso config did not take effect
Closes #5553, related tikv/pd#7519
What is changed and how does it work?
Tests
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.