Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdms: rename pdms-service to service #5558

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Feb 28, 2024

What problem does this PR solve?

ref tikv/pd#7519

What is changed and how does it work?

rename pdms-tso to tso

before
img_v3_028g_22577ee4-3961-45b0-bd59-c596c0175ccg

after
image

Tests

  • Unit test
  • Manual test

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 February 28, 2024 06:53
@ti-chi-bot ti-chi-bot bot added the size/L label Feb 28, 2024
@HuSharp HuSharp removed the request for review from howardlau1999 February 28, 2024 06:59
Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2024

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.71%. Comparing base (8925197) to head (21d2956).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5558      +/-   ##
==========================================
- Coverage   61.49%   60.71%   -0.79%     
==========================================
  Files         235      246      +11     
  Lines       30097    33967    +3870     
==========================================
+ Hits        18509    20622    +2113     
- Misses       9737    11411    +1674     
- Partials     1851     1934      +83     
Flag Coverage Δ
e2e 22.00% <0.00%> (?)
unittest 61.49% <83.33%> (-0.01%) ⬇️

@HuSharp
Copy link
Contributor Author

HuSharp commented Feb 28, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 28, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Feb 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-28 07:17:44.028832638 +0000 UTC m=+1032752.776455749: ☑️ agreed by csuzhangxc.
  • 2024-02-28 07:17:52.724137346 +0000 UTC m=+1032761.471760457: ✖️🔁 reset by csuzhangxc.

Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2024

New changes are detected. LGTM label has been removed.

@csuzhangxc
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc csuzhangxc merged commit 22e06d0 into pingcap:master Feb 29, 2024
12 of 13 checks passed
@HuSharp HuSharp deleted the rename_pdms branch February 29, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants