Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: add resilience to single TiKV crash (#5572) #5585

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5572

What problem does this PR solve?

This PR provides the resilience to a single TiKV crash due to wal corruption at restore

What is changed and how does it work?

Add a new attribute spec.tolerateSingleTiKVOutage to restore CR. When it's set to true, restore to the tc can tolerate a single TiKV outage due to wal log corruption issue.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-5572-to-release-1.5 branch from 1a2944c to fa0a56e Compare March 20, 2024 13:08
Copy link
Contributor

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: BornChanger <dawn_catcher@126.com>
@csuzhangxc csuzhangxc merged commit 78171f7 into pingcap:release-1.5 Mar 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants