Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep before shutdown backup container (#5454) #5606

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5454

What problem does this PR solve?

Add sleep before shutdown backup container

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@BornChanger
Copy link
Contributor

/retest

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.52%. Comparing base (724031b) to head (1270aa3).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5606      +/-   ##
===============================================
+ Coverage        61.54%   64.52%   +2.97%     
===============================================
  Files              229      242      +13     
  Lines            29331    33297    +3966     
===============================================
+ Hits             18052    21484    +3432     
- Misses            9498     9950     +452     
- Partials          1781     1863      +82     
Flag Coverage Δ
e2e 34.12% <ø> (?)
unittest 61.53% <ø> (-0.01%) ⬇️

@BornChanger
Copy link
Contributor

/run-pull-e2e-kind

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-03 17:05:12.103966629 +0000 UTC m=+463573.631507168: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 3, 2024
@BornChanger
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

@BornChanger: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor

/approve

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 4fd903f into pingcap:release-1.5 Apr 4, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants