br: clean volumes when restore volume failed (#5634) #5639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5634
What problem does this PR solve?
Add cleaning volumes function when restore volume failed. Then we can avoid volume leak
Closes #5638
What is changed and how does it work?
Code changes
Tests
manual test steps:
VolumeComplete
toFailed
to mock restore volume failed scenariotidb.pingcap.com/tikv-volumes-ready
to block tikv creation, then delete the tikv statefulset to detach the EBS volumesSide effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.