Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BR]initialize status metric to zero (#5637) #5648

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5637

What problem does this PR solve?

Currently when the federated manager restart we lost the metrics, and the new status metric will start with value 1. In our dashboard we are measuring success/fail backups by increase() function, current implementation will cause we lost the back up status when federated manager restarts.

This PR set the status counter to 0 before it emit the first metric.

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


add function addZeroToBackupStatusMetric to set metric to zero when federated manager restarts

update legacy code

fix compile error
Copy link
Contributor

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tennix for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 May 15, 2024 12:40
@csuzhangxc csuzhangxc merged commit 68bbc06 into pingcap:release-1.5 May 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants