refine fullbackup #570
Merged
refine fullbackup #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregwebs
reviewed
Jun 11, 2019
| {{ .Values.backupOptions }} | ||
|
|
||
| echo "Reset TiKV GC life time to 10m" | ||
| /usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} -p${TIDB_PASSWORD} -Nse "update mysql.tidb set variable_value='10m' where variable_name='tikv_gc_life_time';" |
There was a problem hiding this comment.
It looks like this assumes 10 minutes was previously set, but I think we need to get the original value and set it back to that original value.
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
weekface
commented
Jun 12, 2019
| - -pd-urls=http://{{ .Values.clusterName }}-pd:2379 | ||
| - -cmd=generate_meta | ||
| - -data-dir=/savepoint-dir | ||
| command: ["/bin/sh", "-c", "cp /binlogctl /shared-dir/"] |
There was a problem hiding this comment.
The initContainer only copy binlogctl to the backup container
cofyc
previously approved these changes
Jun 13, 2019
|
/run-e2e-tests |
no enough space left? |
|
/run-e2e-tests |
|
/run-e2e-tests |
xiaojingchen
previously approved these changes
Jun 14, 2019
tennix
reviewed
Jun 14, 2019
| @@ -1,26 +1,46 @@ | |||
| set -euo pipefail | |||
|
|
|||
| host=`echo {{ .Values.clusterName }}_TIDB_SERVICE_HOST | tr '[a-z]' '[A-Z]' | tr '-' '_'` | |||
| host_env=`echo {{ .Values.clusterName }}_TIDB_SERVICE_HOST | tr '[a-z]' '[A-Z]' | tr '-' '_'` | |||
| host=`eval echo '${'$host_env'}'` | |||
There was a problem hiding this comment.
host=$(getent hosts {{ .Values.clusterName }}-tidb | head | awk '{print $1}')
|
/run-e2e-tests |
|
/run-e2e-tests |
|
@tennix ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
This pr passed the stability tests on cluster 1.
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: