Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: support schema change by tls #5708

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Aug 8, 2024

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from husharp, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL label Aug 8, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 8, 2024

/test all

Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2024

@HuSharp: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 21.87500% with 100 lines in your changes missing coverage. Please review.

Project coverage is 34.63%. Comparing base (9ef26f8) to head (1db5286).
Report is 18 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9ef26f8) and HEAD (1db5286). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9ef26f8) HEAD (1db5286)
unittest 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5708       +/-   ##
===========================================
- Coverage   61.47%   34.63%   -26.84%     
===========================================
  Files         235      219       -16     
  Lines       30653    30722       +69     
===========================================
- Hits        18843    10640     -8203     
- Misses       9920    18682     +8762     
+ Partials     1890     1400      -490     
Flag Coverage Δ
e2e 34.63% <21.87%> (?)
unittest ?

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/run-all-tests

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 13, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 14, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 14, 2024

/run-pull-e2e-kind-across-kubernetes

@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 14, 2024

/run-pull-e2e-kind

@HuSharp
Copy link
Contributor Author

HuSharp commented Sep 12, 2024

/run-all-tests

Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Sep 12, 2024

/run-all-tests

Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Sep 14, 2024

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants